[Skiboot] [PATCH] FSP: Add check to detect FSP R/R inside fsp_sync_msg()

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jun 21 18:44:06 AEST 2017

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> OPAL sends MBOX message to FSP and updates message state from fsp_msg_queued
> -> fsp_msg_sent. fsp_sync_msg() queues message and waits until we get response
> from FSP. During FSP R/R we move outstanding MBOX messages from msgq to rr_queue
> including inflight message (fsp_reset_cmdclass()). But we are not resetting
> inflight message state.
> In extreme croner case where we sent message to FSP via fsp_sync_msg() path
> and FSP R/R happens before getting respose from FSP, then we will endup waiting
> in fsp_sync_msg() until everything becomes normal.
> This patch adds fsp_in_rr() check to fsp_sync_msg() and return error to caller
> if FSP is in R/R.
> CC: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

Thanks, merged to master as of c74e88e8614de0a82cba5c30812d5aa39db747a9

Also to skiboot-5.4.x as of cb26e20d21bdf02fe916470613be99a2be412660
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list