[Skiboot] [PATCH] FSP: Add check to detect FSP R/R inside fsp_sync_msg()
Ananth N Mavinakayanahalli
ananth at linux.vnet.ibm.com
Tue Jun 20 20:21:56 AEST 2017
On Tue, Jun 20, 2017 at 02:23:55PM +0530, Vasant Hegde wrote:
> OPAL sends MBOX message to FSP and updates message state from fsp_msg_queued
> -> fsp_msg_sent. fsp_sync_msg() queues message and waits until we get response
> from FSP. During FSP R/R we move outstanding MBOX messages from msgq to rr_queue
> including inflight message (fsp_reset_cmdclass()). But we are not resetting
> inflight message state.
> In extreme croner case where we sent message to FSP via fsp_sync_msg() path
> and FSP R/R happens before getting respose from FSP, then we will endup waiting
> in fsp_sync_msg() until everything becomes normal.
> This patch adds fsp_in_rr() check to fsp_sync_msg() and return error to caller
> if FSP is in R/R.
> CC: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
More information about the Skiboot