[Skiboot] [PATCH] mambo: Match whole string when looking up symbols with linsym/skisym

Stewart Smith stewart at linux.vnet.ibm.com
Tue Jun 6 21:21:35 AEST 2017


Michael Ellerman <mpe at ellerman.id.au> writes:
> linsym/skisym use a regex to match the symbol name, and accepts a
> partial match against the entry in the symbol map, which can lead to
> somewhat confusing results, eg:
>
>   systemsim % linsym early_setup
>   0xc000000000027890
>   systemsim % linsym early_setup$
>   0xc000000000aa8054
>   systemsim % linsym early_setup_secondary
>   0xc000000000027890
>
> I don't think that's the behaviour we want, so append a $ to the name so
> that the symbol has to match against the whole entry, eg:
>
>   systemsim % linsym early_setup
>   0xc000000000aa8054
>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> ---
>  external/mambo/mambo_utils.tcl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, merged to master as of 5d919e412090951ae0139dc8b7f1223fba5ada79
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list