[Skiboot] [PATCH v3] platform/astbmc: Do not delete compatible property

[Vasant Hegde]

On 07/25/2017 11:01 AM, Jeremy Kerr wrote:
> Hi Vasant,
>
>> P9 onwards OPAL is building device tree for BMC based system using
>> HDAT. We are populating bmc/compatible node with bmc version. Hence
>> do not delete this property.
>
> ast_bmc_fixup_bmc_sensors() does a few things, but I think I see what
> you're getting at here; this change looks good to me.
>
> However, we should probably validate that the generated DT actually
> looks OK before we do a release with this patch (and thus releasing
> those compatible strings into the wild). To help with that, could you
> provide a sample of the generated tree?

Jeremy,

Please find the BMC section of device tree. Let me know if you need full dts output.


	bmc {
		compatible = "ibm,ast2500,openbmc";
		#address-cells = <0x1>;
		#size-cells = <0x0>;
		phandle = <0x2>;

		sensors {
			#address-cells = <0x1>;
			#size-cells = <0x0>;
			phandle = <0x3>;

			sensor at a7 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x19>;
				reg = <0xa7>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at ae {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x20>;
				reg = <0xae>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at 0 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x14>;
				reg = <0x0>;
				ipmi-sensor-type = <0xcc>;
			};

			sensor at a5 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x17>;
				reg = <0xa5>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at ac {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1e>;
				reg = <0xac>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at 5a {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x16>;
				reg = <0x5a>;
				ipmi-sensor-type = <0x7>;
			};

			sensor at 9 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x12>;
				reg = <0x9>;
				ipmi-sensor-type = <0xc8>;
			};

			sensor at b3 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x21>;
				reg = <0xb3>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at aa {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1c>;
				reg = <0xaa>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at 7 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xf>;
				reg = <0x7>;
				ipmi-sensor-type = <0xc3>;
			};

			sensor at e {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x6>;
				reg = <0xe>;
				ipmi-sensor-type = <0xc7>;
			};

			sensor at 5 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xb>;
				reg = <0x5>;
				ipmi-sensor-type = <0x1f>;
			};

			sensor at c {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x4>;
				reg = <0xc>;
				ipmi-sensor-type = <0xc7>;
			};

			sensor at 3 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x9>;
				reg = <0x3>;
				ipmi-sensor-type = <0xf>;
			};

			sensor at a {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xd>;
				reg = <0xa>;
				ipmi-sensor-type = <0xc1>;
			};

			sensor at a8 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1a>;
				reg = <0xa8>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at 1 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xa>;
				reg = <0x1>;
				ipmi-sensor-type = <0x12>;
			};

			sensor at a6 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x18>;
				reg = <0xa6>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at ad {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1f>;
				reg = <0xad>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at b4 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x22>;
				reg = <0xb4>;
				ipmi-sensor-type = <0xc>;
			};

			sensor at ab {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1d>;
				reg = <0xab>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at 8 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x11>;
				reg = <0x8>;
				ipmi-sensor-type = <0xc6>;
			};

			sensor at f {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x7>;
				reg = <0xf>;
				ipmi-sensor-type = <0xc7>;
			};

			sensor at 6 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xe>;
				reg = <0x6>;
				ipmi-sensor-type = <0xc2>;
			};

			sensor at d {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x5>;
				reg = <0xd>;
				ipmi-sensor-type = <0xc7>;
			};

			sensor at 59 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x15>;
				reg = <0x59>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at 10 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x8>;
				reg = <0x10>;
				ipmi-sensor-type = <0xc7>;
			};

			sensor at 4 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x10>;
				reg = <0x4>;
				ipmi-sensor-type = <0xc4>;
			};

			sensor at b {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x13>;
				reg = <0xb>;
				ipmi-sensor-type = <0xca>;
			};

			sensor at a9 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0x1b>;
				reg = <0xa9>;
				ipmi-sensor-type = <0x1>;
			};

			sensor at 2 {
				compatible = "ibm,ipmi-sensor";
				phandle = <0xc>;
				reg = <0x

-Vasant