[Skiboot] [PATCH v3] platform/astbmc: Do not delete compatible property

Jeremy Kerr jk at ozlabs.org
Tue Jul 25 15:31:23 AEST 2017

Hi Vasant,

> P9 onwards OPAL is building device tree for BMC based system using
> HDAT. We are populating bmc/compatible node with bmc version. Hence
> do not delete this property.

ast_bmc_fixup_bmc_sensors() does a few things, but I think I see what
you're getting at here; this change looks good to me.

However, we should probably validate that the generated DT actually
looks OK before we do a release with this patch (and thus releasing
those compatible strings into the wild). To help with that, could you
provide a sample of the generated tree?

Any changes there would be to separate code though, so:

Acked-by: Jeremy Kerr <jk at ozlabs.org>



More information about the Skiboot mailing list