[Skiboot] [PATCH] core/pci: Fix mem-leak on fast-reboot

Stewart Smith stewart at linux.vnet.ibm.com
Tue Jul 25 17:47:35 AEST 2017

Stewart Smith <stewart at linux.vnet.ibm.com> writes:
> Matt Brown <matthew.brown.dev at gmail.com> writes:
>> On Thu, Jul 20, 2017 at 5:06 PM, Stewart Smith
>> <stewart at linux.vnet.ibm.com> wrote:
>>> Matt Brown <matthew.brown.dev at gmail.com> writes:
>>>> Fast-reboot has a memory leak which causes the system to crash after about
>>>> 250 fast-reboots. The patch fixes the memory leak.
>>>> The cause of the leak was the pci_device's being freed, without freeing
>>>> the pci_slot within it.
>>> How many have you gotten with the patch?
>>> Or did it just take too long and you gave up? :)
>> It should hopefully go forever!
>> I did about a dozen reboots and there wasn't any decline in the free
>> memory.
> I'm up to this on Habanero:
> [ 1131.216889103,5] RESET: Initiating fast reboot 28...

So, I got to 574 (twice) and then around that number we hit something
strange where we crash pretty hard, but I haven't had time to debug.

That being said, this certainly fixes the previous issue.


Merged to master as of 57f2e785155d9b3ea40a845987579131c04302ff
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list