[Skiboot] [PATCH] core/pci: Fix mem-leak on fast-reboot

Stewart Smith stewart at linux.vnet.ibm.com
Thu Jul 20 17:40:22 AEST 2017

Matt Brown <matthew.brown.dev at gmail.com> writes:

> On Thu, Jul 20, 2017 at 5:06 PM, Stewart Smith
> <stewart at linux.vnet.ibm.com> wrote:
>> Matt Brown <matthew.brown.dev at gmail.com> writes:
>>> Fast-reboot has a memory leak which causes the system to crash after about
>>> 250 fast-reboots. The patch fixes the memory leak.
>>> The cause of the leak was the pci_device's being freed, without freeing
>>> the pci_slot within it.
>> How many have you gotten with the patch?
>> Or did it just take too long and you gave up? :)
> It should hopefully go forever!
> I did about a dozen reboots and there wasn't any decline in the free
> memory.

I'm up to this on Habanero:
[ 1131.216889103,5] RESET: Initiating fast reboot 28...

and I'm up to swearing at an FSP for Tuleta :)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list