[Skiboot] [PATCH v5 2/5] hdata: Add 'primary' property to master chip xscom node

[Vasant Hegde]

On 07/24/2017 03:26 AM, Benjamin Herrenschmidt wrote:
> On Sun, 2017-07-23 at 17:00 +0530, Vasant Hegde wrote:
>> +static void add_xscom_primary_property(const struct HDIF_common_hdr *hdif,
>> +                                      struct dt_node *xscom)
>> +{
>> +       const void *pnor;
>> +       uint32_t size = 0;
>> +
>> +       pnor = HDIF_get_idata(hdif, SPPCRD_IDATA_PNOR_INFO, &size);
>> +       /* PNOR is attached to master chip only */
>> +       if (pnor && size > 0) {
>> +               dt_add_property(xscom, "primary", NULL, 0);
>> +               prlog(PR_DEBUG, "XSCOM: Found primary chip ID\n");
>> +       }
>> +}
>
> Is that true of multi-drawers machine ? I was under the impression that
> such systems had a PNOR per node ...

You are right. It won't work in multi-drawers. I will check with FW folks and 
fix this in next iteration.

Thanks!