[Skiboot] [PATCH v5 2/5] hdata: Add 'primary' property to master chip xscom node

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Jul 24 07:56:12 AEST 2017


On Sun, 2017-07-23 at 17:00 +0530, Vasant Hegde wrote:
> +static void add_xscom_primary_property(const struct HDIF_common_hdr *hdif,
> +                                      struct dt_node *xscom)
> +{
> +       const void *pnor;
> +       uint32_t size = 0;
> +
> +       pnor = HDIF_get_idata(hdif, SPPCRD_IDATA_PNOR_INFO, &size);
> +       /* PNOR is attached to master chip only */
> +       if (pnor && size > 0) {
> +               dt_add_property(xscom, "primary", NULL, 0);
> +               prlog(PR_DEBUG, "XSCOM: Found primary chip ID\n");
> +       }
> +}

Is that true of multi-drawers machine ? I was under the impression that
such systems had a PNOR per node ...

In fact it would be possible to construe a system where each chip boots
independently off its own PNOR before the "connect".

There should be a different way of identifying the "primary" SBE via
HDAT...

Ben.



More information about the Skiboot mailing list