[Skiboot] [PATCH 2/9] npu2: Fix indirect SCOM addresses
Andrew Donnellan
andrew.donnellan at au1.ibm.com
Thu Jul 20 18:58:34 AEST 2017
On 15/07/17 01:39, Reza Arbab wrote:
> Change these values for POWER9 DD2, but keep backwards compatibility.
>
> Cc: Alistair Popple <alistair at popple.id.au>
> Signed-off-by: Reza Arbab <arbab at linux.vnet.ibm.com>
Upon further review...
> static void npu2_scom_write(uint64_t gcid, uint64_t scom_base,
> uint64_t reg, uint64_t size,
> uint64_t val)
> {
> + uint64_t isd = is_p9dd1() ? NPU2_DD1_MISC_SCOM_IND_SCOM_DATA :
> + NPU2_MISC_SCOM_IND_SCOM_DATA;
> +
> npu2_scom_set_addr(gcid, scom_base, reg, size);
> - xscom_write(gcid, scom_base + NPU2_MISC_SCOM_IND_SCOM_DATA, val);
> + xscom_write(gcid, scom_base + isd, val);
> }
>
> static uint64_t npu2_scom_read(uint64_t gcid, uint64_t scom_base,
Do we need to do the same for reads?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the Skiboot
mailing list