[Skiboot] [PATCH 09/13] xive: Add some dump facility

[Stewart Smith]

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> diff --git a/include/opal-api.h b/include/opal-api.h
> index 800f396..bbc0e96 100644
> --- a/include/opal-api.h
> +++ b/include/opal-api.h
> @@ -196,7 +196,9 @@
>  #define OPAL_XIVE_SET_VP_INFO			138
>  #define OPAL_XIVE_ALLOCATE_IRQ			139
>  #define OPAL_XIVE_FREE_IRQ			140
> -#define OPAL_LAST				140
> +#define OPAL_XIVE_SYNC				141

OPAL_XIVE_SYNC? I don't seem to see a definition or implementation
anywhere.

> +#define OPAL_XIVE_DUMP				142

In order to avoid confustion with the various DUMP calls, what about a
naming convention of OPAL_foo_DEBUG_DUMP ?

> +#define OPAL_LAST				142

This patch will also conflict with the several reserved IDs I put in for
XIVE... probably simple fixup, but a rebase could be good?


-- 
Stewart Smith
OPAL Architect, IBM.