[Skiboot] [PATCH] capi: Add new flags in the device-tree

[christophe lombard]

Le 04/12/2017 à 03:44, Stewart Smith a écrit :
> Christophe Lombard <clombard at linux.vnet.ibm.com> writes:
>> We need to add new CAPI flags in the device-tree (PHB DT node)
>> indicating which version of CAPI are supported. The cxl module will
>> handle these flags instead of using PVR values.
>>
>> Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
>> ---
>>   hw/phb3.c          | 3 ++-
>>   hw/phb4.c          | 3 ++-
>>   include/opal-api.h | 2 ++
>>   3 files changed, 6 insertions(+), 2 deletions(-)
> 
> Can you please document the ibm,capi-flags property somewhere in
> doc/device-tree?
> 

will do.

> Seeing as you're adding a bit for CAPI1 (I'm not sure why it's CAIA1
> rather than CAPI1 though, probably good to clarify), and we haven't


CAPI1 or CAIA1 is similar. We can keep CAPI1.

> previously set this bit, is this bit meaningful at all? perhaps it's
> better to invert hte meaning as previous versions will have set it to 0,
> so if 1 indicates the *absence* of CAPI1 rather than 0, then the OS code
> would be simpler?
> 
Right, we have to be care for compatibility with old versions.
Thanks