[Skiboot] [PATCH] capi: Add new flags in the device-tree

Stewart Smith stewart at linux.vnet.ibm.com
Mon Dec 4 13:44:33 AEDT 2017

Christophe Lombard <clombard at linux.vnet.ibm.com> writes:
> We need to add new CAPI flags in the device-tree (PHB DT node)
> indicating which version of CAPI are supported. The cxl module will
> handle these flags instead of using PVR values.
> Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
> ---
>  hw/phb3.c          | 3 ++-
>  hw/phb4.c          | 3 ++-
>  include/opal-api.h | 2 ++
>  3 files changed, 6 insertions(+), 2 deletions(-)

Can you please document the ibm,capi-flags property somewhere in

Seeing as you're adding a bit for CAPI1 (I'm not sure why it's CAIA1
rather than CAPI1 though, probably good to clarify), and we haven't
previously set this bit, is this bit meaningful at all? perhaps it's
better to invert hte meaning as previous versions will have set it to 0,
so if 1 indicates the *absence* of CAPI1 rather than 0, then the OS code
would be simpler?

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list