[Skiboot] [PATCH 1/3] npu2: hw-procedures: Add comments denoting procedure number

Reza Arbab arbab at linux.vnet.ibm.com
Thu Aug 31 08:38:25 AEST 2017


There are comments in this file to indicate where each numbered
procedure from the programming guide is implemented, for easy searching.

Add a couple which were missing.

Signed-off-by: Reza Arbab <arbab at linux.vnet.ibm.com>
---
 hw/npu2-hw-procedures.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c
index c9e7673..ac5c919 100644
--- a/hw/npu2-hw-procedures.c
+++ b/hw/npu2-hw-procedures.c
@@ -312,6 +312,7 @@ static uint32_t phy_reset_complete(struct npu2_dev *ndev)
 }
 DEFINE_PROCEDURE(phy_reset, phy_reset_wait, phy_reset_complete);
 
+/* Procedure 1.2.6 - I/O PHY Tx Impedance Calibration */
 static uint32_t phy_tx_zcal(struct npu2_dev *ndev)
 {
 	if (ndev->npu->tx_zcal_complete[ndev->index > 2])
@@ -502,6 +503,7 @@ static uint32_t phy_enable_tx_rxcal(struct npu2_dev *ndev)
 }
 DEFINE_PROCEDURE(phy_enable_tx_rxcal);
 
+/* Procedure 1.2.9 - Disable Downstream Link Training */
 static uint32_t phy_disable_tx_rxcal(struct npu2_dev *ndev)
 {
 	int lane;
-- 
1.8.3.1



More information about the Skiboot mailing list