[Skiboot] [RFC PATCH 03/13] external/pflash: Use ffs_entry_user_to_string() to standardise flag strings
Cyril Bur
cyril.bur at au1.ibm.com
Wed Aug 30 11:48:26 AEST 2017
On Tue, 2017-08-29 at 19:34 +1000, Stewart Smith wrote:
> Cyril Bur <cyril.bur at au1.ibm.com> writes:
> > Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> > ---
> > external/pflash/pflash.c | 14 +++++---------
> > external/pflash/test/results/01-info.out | 10 +++++-----
> > 2 files changed, 10 insertions(+), 14 deletions(-)
>
> I think it'd be great if the available flags were in --help as
> well. It's probably a good idea to document that CSV format somewhere,
> and I can't think of anything better than --help atm :)
>
Yeah, I guess this patch was a bit halfbaked at trying to standardise
the character value of a flag - more than happy to add it to --help.
Might be worth reworking the patch to libffs to do more.
More information about the Skiboot
mailing list