[Skiboot] [PATCH 4/5] hdata: Add memory hierarchy under xscom node

[Vasant Hegde]

On 08/22/2017 12:19 PM, Vasant Hegde wrote:
> We have memory to chip mapping. But doesn't have complete memory hierarchy.
> This patch adds memory hierarchy under xscom node. This is specific to
> P9 system as these hierarchy may change between processor generation.
>
> It uses memory controller ID details and populates nodes like:
>   xscom@<addr>/mcbist@<mcbist_id>/mcs@<mcs_id>/mca@<mca_id>/dimm@<resource_id>
>
> Also this patch adds few properties under dimm node.
> Finally make sure xscom nodes created before calling memory_parse().
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  hdata/memory.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  hdata/spira.c  |   6 +--
>  2 files changed, 119 insertions(+), 5 deletions(-)
>

.../...

> diff --git a/hdata/spira.c b/hdata/spira.c
> index b58be7c..8833271 100644
> --- a/hdata/spira.c
> +++ b/hdata/spira.c
> @@ -1314,12 +1314,12 @@ int parse_hdat(bool is_opal)
>  	/* IPL params */
>  	add_iplparams();
>
> -	/* Parse MS VPD */
> -	memory_parse();
> -
>  	/* Add XSCOM node (must be before chiptod, IO and FSP) */
>  	add_xscom();
>
> +	/* Parse MS VPD */
> +	memory_parse();
> +

This breaks hdata test cases. Will fix it in next version.

-Vasant