[Skiboot] [PATCH 1/4] external/pflash: Silence false positive Coverity CID 163739

Stewart Smith stewart at linux.vnet.ibm.com
Tue Aug 22 14:57:36 AEST 2017

Cyril Bur <cyril.bur at au1.ibm.com> writes:
> Several of the cases in the getopt loop take the optarg pointer and pass
> it to functions which will dereference it. There is currently no bug as
> all of these are marked to getopt as having a requirement argument so
> optarg will never be null.
> The rationale for this patch is firstly to silence coverity as it is
> fairly simple to do. More importantly having a brand new version of this
> Coverity error appear in the event of a future mistake with optional
> arguments to getopt will be useful.
> Fixes: CID 163739
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---
>  external/pflash/pflash.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Series merged to master as of 916bc2d8da8fee71653c325cc752f0ce901a58a2

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list