[Skiboot] [PATCH] core/init: Add ibm, processor-storage-keys property to CPU DT node.

Thiago Jung Bauermann bauerman at linux.vnet.ibm.com
Fri Aug 18 01:44:28 AEST 2017


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:

> On 08/17/2017 05:19 AM, Thiago Jung Bauermann wrote:
>> LoPAPR says:
>>
>
> .../...
>
>> Signed-off-by: Thiago Jung Bauermann <bauerman at linux.vnet.ibm.com>
>> ---
>>
>> This is used by patch 25 of Ram Pai's series which makes Linux support
>> storage keys:
>>
>> https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-July/161230.html
>>
>> I will submit a patch for KVM so that it can pass the property along
>> to its guests in the next few days.
>>
>>  core/init.c | 25 +++++++++++++++++++++++++
>
> Thiago,
>
> Is there a specific reason to add this code under init.c?
>
> I think its better to add this code where we create /cpus node. 
> (hdata/cpu-common.c).

That's where I put it at first, but then it only works on platforms
where the device tree is contructed from hdata. It doesn't work on Mambo
nor QEMU, for instance (I didn't test this option on the Firenze
machine).

Where it is now, it will work regardless where the device tree comes
from.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center



More information about the Skiboot mailing list