[Skiboot] [PATCH] NPU2: fix missing unlock

Stewart Smith stewart at linux.vnet.ibm.com
Tue Aug 15 14:38:46 AEST 2017


Found by coccinelle using a slightly modified
http://coccinelle.lip6.fr/rules/mut.html spatch

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/npu2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/npu2.c b/hw/npu2.c
index 74e332551085..0eb787c61f5e 100644
--- a/hw/npu2.c
+++ b/hw/npu2.c
@@ -1865,8 +1865,8 @@ static int opal_npu_destroy_context(uint64_t phb_id, uint64_t pid, uint64_t bdf)
 
 	/* And zero the entry */
 	npu2_write(p, NPU2_XTS_PID_MAP + id*0x20, 0);
-	unlock(&p->lock);
 out:
+	unlock(&p->lock);
 	return rc;
 }
 opal_call(OPAL_NPU_DESTROY_CONTEXT, opal_npu_destroy_context, 3);
-- 
2.13.4



More information about the Skiboot mailing list