[Skiboot] [PATCH 1/2] opal-prd: Disable pnor access interface on FSP system

Jeremy Kerr jk at ozlabs.org
Fri Aug 11 14:49:19 AEST 2017

Hi Vasant,

>> Here you're duplicating the check for the ibm,system-flash property in
>> the libflash code. Why not just use the return value of pnor_init there?
>> We'd want the following logic:
> Yes. its kind of duplicate. But get_dev_mtd and file_init_path() is in
> common code and the error message we print inside these functions may
> confuse in this context.

OK, that makes sense.

One day, we might want to make the error logging in those common
functions a bit more flexible. But for now, this sounds like the best

Acked-by: Jeremy Kerr <jk at ozlabs.org>



More information about the Skiboot mailing list