[Skiboot] [PATCH 4/6] phb4: Prepare for link down when creset called from kernel

[Andrew Donnellan]

On 10/08/17 16:58, Russell Currey wrote:
> phb4_creset() is typically called by functions that prepare the link
> to go down.  In cases where creset() is called directly by the kernel,
> this isn't the case and it can cause issues.  Prepare for link down in
> creset, just like we do in freset and hreset.
> 
> Signed-off-by: Russell Currey <ruscur at russell.cc>

Looks reasonable

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> ---
>   hw/phb4.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/phb4.c b/hw/phb4.c
> index 012a8cdc..b467e369 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -2623,6 +2623,7 @@ static int64_t phb4_creset(struct pci_slot *slot)
>   			do_capp_recovery_scoms(p);
>   #endif
>   
> +		phb4_prepare_link_change(slot, false);
>   		/* Clear error inject register, preventing recursive errors */
>   		xscom_write(p->chip_id, p->pe_xscom + 0x2, 0x0);
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited