[Skiboot] [PATCH 6/6] phb4: Fix reading wrong size registers in EEH dump
Russell Currey
ruscur at russell.cc
Thu Aug 10 16:58:43 AEST 2017
These registers are supposed to be 16bit, and it makes part of the
register dump misleading.
Signed-off-by: Russell Currey <ruscur at russell.cc>
---
hw/phb4.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/phb4.c b/hw/phb4.c
index d13ab8c3..4c7bfe3b 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -1906,7 +1906,7 @@ static void phb4_read_phb_status(struct phb4 *p,
static void phb4_eeh_dump_regs(struct phb4 *p)
{
struct OpalIoPhb4ErrorData *s;
- uint32_t reg;
+ uint16_t reg;
unsigned int i;
if (!verbose_eeh)
@@ -1929,9 +1929,9 @@ static void phb4_eeh_dump_regs(struct phb4 *p)
PHBERR(p, " uncorrErrorStatus = %08x\n", s->uncorrErrorStatus);
/* Two non OPAL API registers that are useful */
- phb4_pcicfg_read32(&p->phb, 0, p->ecap + PCICAP_EXP_DEVCTL, ®);
+ phb4_pcicfg_read16(&p->phb, 0, p->ecap + PCICAP_EXP_DEVCTL, ®);
PHBERR(p, " devctl = %08x\n", reg);
- phb4_pcicfg_read32(&p->phb, 0, p->ecap + PCICAP_EXP_DEVSTAT,
+ phb4_pcicfg_read16(&p->phb, 0, p->ecap + PCICAP_EXP_DEVSTAT,
®);
PHBERR(p, " devStat = %08x\n", reg);
--
2.14.0
More information about the Skiboot
mailing list