[Skiboot] [PATCH] HDAT/device-tree: only add lid-type on pre-POWER9 systems

Stewart Smith stewart at linux.vnet.ibm.com
Wed Aug 9 08:42:45 AEST 2017


Largely a relic of back when we had multiple entry points into OPAL depending
on which mechanism on an FSP we were using to get loaded, this isn't needed
on modern P9 as we only have one entry point (we don't do the PHYP LID hack).

Fixes: https://github.com/open-power/skiboot/issues/82
Reported-by: Pavaman Subramaniyam <pavsubra at linux.vnet.ibm.com>
Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hdata/spira.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hdata/spira.c b/hdata/spira.c
index 58afb9396261..f6dd03dcd92f 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -1,4 +1,4 @@
-/* Copyright 2013-2014 IBM Corp.
+/* Copyright 2013-2017 IBM Corp.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1268,7 +1268,9 @@ int parse_hdat(bool is_opal)
 	 */
 	dt_add_property_cells(dt_root, "#address-cells", 2);
 	dt_add_property_cells(dt_root, "#size-cells", 2);
-	dt_add_property_string(dt_root, "lid-type", is_opal ? "opal" : "phyp");
+
+	if (proc_gen < proc_gen_p9)
+		dt_add_property_string(dt_root, "lid-type", is_opal ? "opal" : "phyp");
 
 	/* Add any BMCs and enable the LPC UART */
 	bmc_parse();
-- 
2.13.4



More information about the Skiboot mailing list