[Skiboot] [PATCH v2] external/gard: Print an error if run on an FSP system

[Vasant Hegde]

On 08/07/2017 10:48 AM, Cyril Bur wrote:
> On Mon, 2017-08-07 at 10:21 +0530, Vasant Hegde wrote:
>> On 08/03/2017 12:38 PM, Cyril Bur wrote:
>>> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
>>> ---
>>>  external/gard/gard.c | 15 ++++++++++++++-
>>>  1 file changed, 14 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/external/gard/gard.c b/external/gard/gard.c
>>> index 4b26a3b8..55e2a924 100644
>>> --- a/external/gard/gard.c
>>> +++ b/external/gard/gard.c
>>> @@ -43,7 +43,9 @@
>>>
>>>  #define CLEARED_RECORD_ID 0xFFFFFFFF
>>>
>>> -#define FDT_ACTIVE_FLASH_PATH "/proc/device-tree/chosen/ibm,system-flash"
>>> +#define FDT_PATH "/proc/device-tree"
>>> +#define FDT_FSP_NODE FDT_PATH"/fsps"
>>
>> How about checking "ibm,system-flash" property and if that doesn't exist then
>> throw an error?
>>
>
> Hi Vasant,

Hi Cyril,

>
> This already happens and not having "ibm,system-flash" doesn't
> necessarily mean the system is FSP. The current message for this is in
> external/common/arch_flash_powerpc.c:

Thanks for the clarification. I missed this.

-Vasant