[Skiboot] [PATCH 4/5] i2c: Remove old hack for bad clock frequency

Oliver O'Halloran oohall at gmail.com
Thu Apr 27 18:50:46 AEST 2017


Tested-by: Oliver O'Halloran <oohall at gmail.com>

On Mon, Apr 24, 2017 at 2:45 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> This hack dates back to ancient P8 hostboots. The value
> it would use if it detected the "bad" value was incorrect
> anyway.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  hw/p8-i2c.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/hw/p8-i2c.c b/hw/p8-i2c.c
> index bfbc31d..c201ad2 100644
> --- a/hw/p8-i2c.c
> +++ b/hw/p8-i2c.c
> @@ -1446,12 +1446,6 @@ static void p8_i2c_init_one(struct dt_node *i2cm, enum p8_i2c_master_type type)
>         /* Local bus speed in Hz */
>         lb_freq = dt_prop_get_u32(i2cm, "clock-frequency");
>
> -       /* XXX HACK for bad HB value */
> -       if (lb_freq == 600000000) {
> -               prlog(PR_ERR, "I2C: Fixing up HB bad clock freq !\n");
> -               lb_freq = 50000000;
> -       }
> -
>         /* Initialise the i2c master structure */
>         master->state = state_idle;
>         master->chip_id = dt_get_chip_id(i2cm);
> --
> 2.9.3
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list