[Skiboot] [PATCH 0/5] MBOX protocol version 2

Cyril Bur cyril.bur at au1.ibm.com
Mon Apr 24 19:14:06 AEST 2017


MBOX V2 with tests. As I'm going away for a month I thought it would
be best if this was sent out.

I wasn't really happy with the way v1 was written so it got a bit of a
restructure - adding v3 should be much easier now. Unfortunately this
has meant a bit of a monster commit - my apologies.

The monster commit problem happened to the tests, I've been working
on those furiously in order to be able to have something to send. The
coverage is ok for basic tests but anyone working on mbox-flash.c
should be made to add more! Unfortunately the tests have been a bit
rushed as they were blocking sending the actual code (which has been
ready for some time).

I'll attempt to online to follow up review,


Cyril Bur (5):
  libflash/mbox-flash: Minor fixups before V2
  hw/lpc-mbox: Use message registers for interrupts
  libflash/mbox-flash: Update to V2 of the protocol
  libflash/mbox-flash: Implement MARK_WRITE_ERASED mbox call
  libflash/test: Add tests for mbox-flash

 .gitignore                   |   1 +
 hw/lpc-mbox.c                | 101 ++++--
 include/lpc-mbox.h           |  15 +-
 include/skiboot.h            |   2 +
 libflash/errors.h            |   2 +
 libflash/mbox-flash.c        | 736 +++++++++++++++++++++++++++++++++++--------
 libflash/test/Makefile.check |  12 +-
 libflash/test/mbox-server.c  | 480 ++++++++++++++++++++++++++++
 libflash/test/mbox-server.h  |  10 +
 libflash/test/stubs.c        |  78 ++++-
 libflash/test/stubs.h        |  27 ++
 libflash/test/test-mbox.c    | 308 ++++++++++++++++++
 12 files changed, 1607 insertions(+), 165 deletions(-)
 create mode 100644 libflash/test/mbox-server.c
 create mode 100644 libflash/test/mbox-server.h
 create mode 100644 libflash/test/stubs.h
 create mode 100644 libflash/test/test-mbox.c


More information about the Skiboot mailing list