[Skiboot] [PATCH] dt: add ibm, tlbiel-congruence-classes-(hash|radix) for tlbiel IS!=0

Benjamin Herrenschmidt benh at kernel.crashing.org
Sun Apr 23 10:38:16 AEST 2017


On Sun, 2017-04-23 at 09:09 +1000, Nicholas Piggin wrote:
> On Sat, 22 Apr 2017 17:56:01 +1000
> Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> 
> > On Sat, 2017-04-22 at 10:58 +1000, Nicholas Piggin wrote:
> > > > From Power ISA 3.0B, Chapter 5. Storage Control 1033, "The
> > > > IS!=0 tlbiel  
> > > 
> > > variants operate on a specified congruence class, requiring a
> > > software
> > > loop where tlbie operates on the entire TLB."  
> > 
> > Overall ok, I would just have called it "tlb-sets-{hash|radix}" to
> > save characters ;-) Also because historically in the DT for cache
> > and
> > TLB geometries we use the terminology "sets".
> 
> I saw that kind of property is usually called sets in dt and kernel,
> but on the other hand I wanted to match the ISA term for this detail
> which may or may not be related to TLB geometry.
> 
> It's easy to change now if you prefer the name changed.

Yes, I prefer the shorter name :-) I don't like properties with overly
long names. Besides in Linux you call it "sets" :-)

> Thanks,
> Nick


More information about the Skiboot mailing list