[Skiboot] [PATCH] pci: Describe PHB diag data size in device tree

Gavin Shan gwshan at linux.vnet.ibm.com
Fri Apr 21 09:46:00 AEST 2017

On Thu, Apr 20, 2017 at 04:46:41PM +1000, Russell Currey wrote:
>Linux hardcodes the PHB diag data buffer at (as of this commit) 8192 bytes.
>This has been enough for P7IOC and PHB3, but the 512 PEs of PHB4 pushes
>the diag data blob over this size.  Rather than just increasing the
>hardcoded size in Linux, provide the size of the diag data blob in the
>device tree so that the OS can dynamically allocate as much as it needs.
>This both enables more space for PHB4 and less wasted memory for P7IOC
>and PHB3.
>P7IOC communicates both hub and PHB data using this buffer, so when
>setting the size, use whichever struct is largest.
>Signed-off-by: Russell Currey <ruscur at russell.cc>

Reviewed-by: Gavin Shan <gwshan at linux.vnet.ibm.com>

"pci" in the subject means you're changing the code in core/pci*.c,
but I usually use "core/pci" for this case. For this particular one,
it would be: hw/phb: xxxxxxxxxxxxxxxxxxxx. Don't have to change this
time as it's just nit-picky comments.


More information about the Skiboot mailing list