[Skiboot] [PATCH V2] occ: irq: Fix SCOM address and irq reasons for OCC_MISC register

Stewart Smith stewart at linux.vnet.ibm.com
Fri Apr 7 11:14:16 AEST 2017

Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
>  void occ_send_dummy_interrupt(void)
>  {
>  	struct psi *psi;
>  	struct proc_chip *chip = get_chip(this_cpu()->chip_id);
>  	/* Emulators and P7 doesn't do this */
> -	if (proc_gen != proc_gen_p8 || chip_quirk(QUIRK_NO_OCC_IRQ))
> +	if (proc_gen != proc_gen_p8 ||  proc_gen != proc_gen_p9 ||
> +	    chip_quirk(QUIRK_NO_OCC_IRQ))
>  		return;

Won't this always evaluate to true?

on p9:
not p8 (true) or not p9 (false) or quirk (false) = true
on p8:
not p8 (false) or not p9 (true) or quirk (false) = true

proc_gen < p8 would work.

(in future, when we have a new chip that doesn't have OCC_IRQ working
yet, we could always just add in the quirk)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list