[Skiboot] [PATCH] hw/fsp/rtc: read/write cached rtc tod on fsp hir.

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Apr 3 16:43:05 AEST 2017

On 04/03/2017 07:27 AM, Pridhiviraj Paidipeddi wrote:
> Currently fsp-rtc reads/writes the cached RTC TOD on an fsp
> reset. Use latest fsp_in_rr() function to properly read the cached rtc
> value when fsp reset initiated by the hir.


Looks like we are not triggering fsp_start_rr() for host initiated FSP R/R. 
While this patch works for
RTC we may hit issues in some other place.

Can you try with below patch?

diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
index a0c5a78..7321e63 100644
--- a/hw/fsp/fsp.c
+++ b/hw/fsp/fsp.c
@@ -1571,6 +1571,7 @@ static void __fsp_poll(bool interrupt)
         /* Handle host initiated resets */
         if (fsp_in_hir(fsp)) {
                 fsp_hir_poll(fsp, iop->psi);
+               fsp_start_rr(fsp);


More information about the Skiboot mailing list