[Skiboot] [PATCH v2 0/2] opal-prd: Fix ignored error reporting on xscom operations, introduce prd flags

Stewart Smith stewart at linux.vnet.ibm.com
Fri Sep 16 16:25:31 AEST 2016


Jeremy Kerr <jk at ozlabs.org> writes:
> Hi all,
>
> Currently, we have a bug in opal-prd where we do not properly report
> errors from xscom read/write ioctls returned from the kernel / firmware.
>
> Patch 2 in this series fixes this issue.
>
> However, we'd also like to report to HBRT that the fix is present. Patch
> 1 introduces a get_prd_flags() callback to the hostboot interface, to
> allow indicications of variations in behaviour like the fix above.
>
> Dan: this is a proposed change to struct host_interfaces, so we'll need
> an Acked-by from your side before merging.
>
> Cheers,
>
>
> Jeremy
>
> ---
> v2:
>   - rename callback to get_interface_capabilities
>   - implement capability sets
>
> Benjamin Herrenschmidt (1):
>   opal-prd: Fix error code from scom_read & scom_write
>
> Jeremy Kerr (1):
>   opal-prd: Add get_interface_capabilities to host interfaces
>
>  external/opal-prd/hostboot-interface.h | 24 +++++++++++++++++++++++-
>  external/opal-prd/opal-prd.c           | 22 ++++++++++++++++------
>  external/opal-prd/thunk.S              |  3 ++-
>  3 files changed, 41 insertions(+), 8 deletions(-)

Seeing as Dan said it looked okay, merged to master as of
925f03c184f42104a1ebd676f4d3c3d50b8a44b8.

and into 5.3.x as of 97d7d3ecbd4d44bdd92f1b5d236723bf7bdfed38

I'm guessing that this doesn't need to go back into 5.1.x ?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list