[Skiboot] [PATCH v2 0/2] opal-prd: Fix ignored error reporting on xscom operations, introduce prd flags

[Daniel M Crowell]

The interface looks good to me.

--
Dan Crowell
Senior Software Engineer - Power Systems Enablement Firmware
IBM Rochester: t/l 553-2987
dcrowell at us.ibm.com



From:   Jeremy Kerr <jk at ozlabs.org>
To:     skiboot at lists.ozlabs.org, Daniel M Crowell/Rochester/IBM at IBMUS
Cc:     Benjamin Herrenschmidt <benh at kernel.crashing.org>, Corey 
Swenson/Rochester/IBM at IBMUS, Patrick Barrett/Rochester/IBM at IBMUS, Jeremy 
Kerr <jk at ozlabs.org>
Date:   09/14/2016 08:57 PM
Subject:        [PATCH v2 0/2] opal-prd: Fix ignored error reporting on 
xscom operations, introduce prd flags



Hi all,

Currently, we have a bug in opal-prd where we do not properly report
errors from xscom read/write ioctls returned from the kernel / firmware.

Patch 2 in this series fixes this issue.

However, we'd also like to report to HBRT that the fix is present. Patch
1 introduces a get_prd_flags() callback to the hostboot interface, to
allow indicications of variations in behaviour like the fix above.

Dan: this is a proposed change to struct host_interfaces, so we'll need
an Acked-by from your side before merging.

Cheers,


Jeremy

---
v2:
  - rename callback to get_interface_capabilities
  - implement capability sets

Benjamin Herrenschmidt (1):
  opal-prd: Fix error code from scom_read & scom_write

Jeremy Kerr (1):
  opal-prd: Add get_interface_capabilities to host interfaces

 external/opal-prd/hostboot-interface.h | 24 +++++++++++++++++++++++-
 external/opal-prd/opal-prd.c           | 22 ++++++++++++++++------
 external/opal-prd/thunk.S              |  3 ++-
 3 files changed, 41 insertions(+), 8 deletions(-)

-- 
2.7.4





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20160915/68908826/attachment.html>