[Skiboot] [PATCH] HDAT: Fix typo in nest-frequency property

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Sep 16 15:34:22 AEST 2016


On 09/16/2016 09:46 AM, Stewart Smith wrote:
> Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
>> On Thu, Sep 15, 2016 at 03:15:26PM +0530, Vasant Hegde wrote:
>>> nest-frquency -> nest-frequency
>>>
>>> Fixes: 5cda6f6d (platforms/firenze: Fix I2C clock source frequency)
>>> CC: Gavin Shan <gwshan at linux.vnet.ibm.com>
>>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>>
>> Reviewed-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>>
>> There are 3 typoes related to this. I guess it would be nice to
>> fix all of them in one shoot:
>>
>> 1 hdata/spira.c:          dt_add_property_cells(dt_root, "nest-frquency",
>> 2 hdata/test/p8-840-spira.dt:prop: nest-frquency size: 8 val: 0000000077359400
>> 3 hdata/test/p81-811.spira.dt:prop: nest-frquency size: 8 val:
>> 0000000077359400
>
> Ahh yes, if 2 and 3 aren't fixed, then 'make check' will fail.

Sorry for breaking test cases again! I will fix and send v2.

-Vasant

>
> Now... the question is: does anything at all rely on the typo and are we
> breaking ABI by fixing the typo?
>



More information about the Skiboot mailing list