[Skiboot] [PATCH] HDAT: Fix typo in nest-frequency property

Gavin Shan gwshan at linux.vnet.ibm.com
Fri Sep 16 15:00:10 AEST 2016

On Fri, Sep 16, 2016 at 02:16:13PM +1000, Stewart Smith wrote:
>Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
>> On Thu, Sep 15, 2016 at 03:15:26PM +0530, Vasant Hegde wrote:
>>>nest-frquency -> nest-frequency
>>>Fixes: 5cda6f6d (platforms/firenze: Fix I2C clock source frequency)
>>>CC: Gavin Shan <gwshan at linux.vnet.ibm.com>
>>>Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> Reviewed-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>> There are 3 typoes related to this. I guess it would be nice to
>> fix all of them in one shoot:
>> 1 hdata/spira.c:          dt_add_property_cells(dt_root, "nest-frquency",
>> 2 hdata/test/p8-840-spira.dt:prop: nest-frquency size: 8 val: 0000000077359400
>> 3 hdata/test/p81-811.spira.dt:prop: nest-frquency size: 8 val:
>> 0000000077359400
>Ahh yes, if 2 and 3 aren't fixed, then 'make check' will fail.
>Now... the question is: does anything at all rely on the typo and are we
>breaking ABI by fixing the typo?

With the typo, the I2C master's clock source is fixed to 125000000. With the
typo fixed, the I2C master's clock source is set to (nest-frequency / 16)
When the SIPRA's version is equal or bigger than 0x005b. Otherwise, the I2C
master's clock source is fail back to the fixed 125000000. The property
"nest-frequency" is a internally used only as I can see, so it doesn't break
any ABI.


More information about the Skiboot mailing list