[Skiboot] [PATCH 29/40] hw/phb3.c: adjust offset to run CAPP containers

[Stewart Smith]

Frederic Barrat <fbarrat at linux.vnet.ibm.com> writes:
> Le 10/10/2016 à 12:03, Michael Neuling a écrit :
>> On Mon, 2016-10-10 at 19:44 +1100, Stewart Smith wrote:
>>> From: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>>>
>>> This adjusts the CAPP header offset if CAPP is a secure boot container.
>>>
>>> Signed-off-by: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>>> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
>>
>> I just noticed these went in... Did the CAPI team test them at all?
>
>
> Not that I know of. So, aside from the obvious non-regression testing on 
> hardware with no trusted/secure boot, what would it take to test? From 
> what I'm reading, it looks like secure or trusted boot is only available 
> on some open power systems?
>
> Mikey: thanks for bringing it up.

I've reverted 0657bccb778cbe71fc8c00879826ca0217b7010d and
cf39c2a7dd1a2ee9b19a5490f7fa25690b8e8ae3 which introduced these
behaviour changes.

This way, secure mode will abort when trying to load the CAPP partition
but if running normally things will work (and I've tested that).

I'll ask Claudio to respin the load-whole-partition-for-container thing
in a way that keeps things out of phb3.c and instead handles it
completely in the load resource code path, and works with existing
systems (and the broken FFS implementation that op-build uses).

-- 
Stewart Smith
OPAL Architect, IBM.