[Skiboot] [PATCH 29/40] hw/phb3.c: adjust offset to run CAPP containers

[Stewart Smith]

Frederic Barrat <fbarrat at linux.vnet.ibm.com> writes:
> Le 10/10/2016 à 12:03, Michael Neuling a écrit :
>> On Mon, 2016-10-10 at 19:44 +1100, Stewart Smith wrote:
>>> From: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>>>
>>> This adjusts the CAPP header offset if CAPP is a secure boot container.
>>>
>>> Signed-off-by: Claudio Carvalho <cclaudio at linux.vnet.ibm.com>
>>> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
>>
>> I just noticed these went in... Did the CAPI team test them at all?
>
>
> Not that I know of. So, aside from the obvious non-regression testing on 
> hardware with no trusted/secure boot, what would it take to test? From 
> what I'm reading, it looks like secure or trusted boot is only available 
> on some open power systems?
>
> Mikey: thanks for bringing it up.

Hrm... so it does look like this broke something. Crap, it really
shouldn't have gone in then. I guess I know what I'm fixing today and
feeling sheepish about.


-- 
Stewart Smith
OPAL Architect, IBM.