[Skiboot] [PATCH v2 1/6] VAS: Define macros needed by VAS

[Sukadev Bhattiprolu]

Oliver O'Halloran [oohall at gmail.com] wrote:
> > +#include <vas.h>
> > +
> > +__attrconst void init_vas(void)
> > +{
> > +}
> 
> Can you fold the Makefile changes and the vas.c stuff into the next
> patch in this series? It's just noise here and the next patch in the
> series replaces vas.c entirely.

Sure.

<snip>

> > +/* Some VAS Miscellaneous Status and North Control Register bits. */
> > +#define VAS_64K_MODE_MASK              PPC_BIT(0)
> > +#define VAS_64K_MODE                   1
> > +#define VAS_ACCEPT_PASTE_MASK          PPC_BIT(1)
> > +#define VAS_ACCEPT_PASTE               1
> > +#define VAS_QUIESCE_REQ_MASK           PPC_BIT(4)
> > +#define VAS_QUIESCE_REQ                        1
> > +#define VAS_HMI_ACTIVE_MASK            PPC_BIT(58)
> > +#define VAS_HMI_ACTIVE                 1
> > +#define VAS_RG_IDLE_MASK               PPC_BIT(59)
> > +#define VAS_RG_IDLE                    1
> 
> What's going on here? I understand defining the _MASK macros, but why
> define all the others to 1?

Yeah, I will remove those.

Thanks,

Sukadev