[Skiboot] [PATCH] fsp: Don't recurse pollers in ibm_fsp_terminate

Stewart Smith stewart at linux.vnet.ibm.com
Mon Nov 21 08:58:18 AEDT 2016

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> On 11/18/2016 03:56 PM, Vasant Hegde wrote:
>> On 11/18/2016 09:28 AM, Stewart Smith wrote:
>>> If we were to terminate in a poller, we'd call op_display() which
>>> called pollers which hit the recursive poller warning, which ended
>>> in not much fun at all.
>>> This patch will skip the running of pollers and instead run
>>> the FSP poller to set the op-panel display before attn.
> Stewart,
> Unrelated comment ... op_display is FSP specific feature and inside FSP code.But 
> its called from many places including common code.. So in future if we want to 
> introduce platform specific CONFIG then we have to reorganize this code.. Or may 
> be introduce platform specific hook for this ?

I think a hook.

You *may* want to display such a thing on a BMC web UI or something, or
query over IPMI.

Although we may want to put something more sensible on that display than
the incomprehensible jumble of hex we do now.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list