[Skiboot] [PATCH] fsp: Don't recurse pollers in ibm_fsp_terminate

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Nov 18 21:30:00 AEDT 2016


On 11/18/2016 03:56 PM, Vasant Hegde wrote:
> On 11/18/2016 09:28 AM, Stewart Smith wrote:
>> If we were to terminate in a poller, we'd call op_display() which
>> called pollers which hit the recursive poller warning, which ended
>> in not much fun at all.
>>
>> This patch will skip the running of pollers and instead run
>> the FSP poller to set the op-panel display before attn.

Stewart,

Unrelated comment ... op_display is FSP specific feature and inside FSP code.But 
its called from many places including common code.. So in future if we want to 
introduce platform specific CONFIG then we have to reorganize this code.. Or may 
be introduce platform specific hook for this ?

-Vasant




More information about the Skiboot mailing list