[Skiboot] [RFC PATCH 6/7] VAS: Define OPAL_VAS_READ_FIR interface

[Sukadev Bhattiprolu]

Alistair Popple [alistair at popple.id.au] wrote:
> > +	chip = get_chip(chip_id);
> > +	if (!chip)
> > +		return OPAL_PARAMETER;
> > +
> > +	/* FIRs 1,2,4,5 are write-only, just return 0 in them. */
> > +	switch (idx) {
> > +		default: /* fall through to 0 */
> 
> Why fall through and not return OPAL_PARAMETER instead? Falling through makes
> it difficult to add other register indexes in future and have the caller detect
> this.

Good point. Will fix that.

Thanks,

Sukadev