[Skiboot] [PATCH v10 08/17] core/pci: Option for serialized jobs
ruscur at russell.cc
Fri May 13 12:25:26 AEST 2016
On Fri, 2016-05-13 at 10:15 +1000, Gavin Shan wrote:
> On Fri, May 06, 2016 at 04:00:30PM +1000, Russell Currey wrote:
> > On Tue, 2016-05-03 at 15:04 +1000, Gavin Shan wrote:
> > > Currently, the PHB reset and PCI enumeration are done concurrently
> > > on multiple CPU cores. The output messages are interleaved and not
> > > readable enough. This adds a option to do the jobs in serialized
> > > fashion for debugging purpose only. The serialized mode should be
> > > always disabled in field.
> > >
> > > Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> > > ---
> > I wonder if the flag should be named similar to other debug flags in
> > skiboot,
> > like DEBUG_FDT, DEBUG_I2C and whatnot. Maybe DEBUG_PCI? Stewart might have
> > an
> > opinion. Nitpicky, anyway.
> Yeah, I agree it'd better to include a "DEBUG" to indicate it's for debugging
> purpose only. I will rename to DEBUG_PCI_SERIALIZED_PROBE if it sounds good
> to you. Please confirm.
Sounds fine to me.
> > Reviewed-by: Russell Currey <ruscur at russell.cc>
More information about the Skiboot