[Skiboot] [PATCH v10 08/17] core/pci: Option for serialized jobs

Stewart Smith stewart at linux.vnet.ibm.com
Fri May 13 10:33:27 AEST 2016

Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
> Currently, the PHB reset and PCI enumeration are done concurrently
> on multiple CPU cores. The output messages are interleaved and not
> readable enough. This adds a option to do the jobs in serialized
> fashion for debugging purpose only. The serialized mode should be
> always disabled in field.
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>

I think we could accomplish this in the generic code a lot neater, in
core/cpu.c __cpu_queue_job() we could just add:

if (cpu == NULL)
   cpu = this_cpu();

and then we'd be automatically able to pretty easily enable serializing
of things that would otherwise happen in parallel.

(better than ifdef may be something in debug descriptor... although
setting that on boot before things start executing may be casually fun)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list