[Skiboot] [PATCH 14/14] hdata/memory.c: add FWTS annotation for invalid timebase size

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 27 15:32:12 AEST 2016


Requires generate-fwts-olog fixup for regex generation

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hdata/memory.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hdata/memory.c b/hdata/memory.c
index ca21da859274..a8b9955dbecc 100644
--- a/hdata/memory.c
+++ b/hdata/memory.c
@@ -214,6 +214,12 @@ static void add_bus_freq_to_ram_area(struct dt_node *ram_node, u32 chip_id)
 
 	timebase = HDIF_get_idata(pcia, SPPCIA_IDATA_TIMEBASE, &size);
 	if (!timebase || size < sizeof(*timebase)) {
+		/**
+		 * @fwts-label HDATBadTimebaseSize
+		 * @fwts-advice HDAT described an invalid size for timebase,
+		 * which means there's a disagreement between HDAT and OPAL.
+		 * This is most certainly a firmware bug.
+		 */
 		prlog(PR_ERR, "HDAT: Bad timebase size %u @ %p\n", size,
 		      timebase);
 		return;
-- 
2.1.4



More information about the Skiboot mailing list