[Skiboot] [PATCH 13/14] external/fwts: fix regex generation for %p format

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 27 15:32:11 AEST 2016

From: Jeremy Kerr <jk at ozlabs.org>

Currently, we're emitting a non-grouping bracket expression for %p
formats, which isn't supported by regex(7). This change uses the
grouping format instead. The creation of a group has no effect in the
fwts olog code, so this should have no consequence on matches.

Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
 external/fwts/generate-fwts-olog | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/external/fwts/generate-fwts-olog b/external/fwts/generate-fwts-olog
index 7663d3481353..f8cc07818cc6 100755
--- a/external/fwts/generate-fwts-olog
+++ b/external/fwts/generate-fwts-olog
@@ -129,7 +129,7 @@ def message_to_pattern(loc, msg):
         elif c == 'x':
             return '[0-9a-f]+'
         elif c == 'p':
-            return '(?:0x[0-9a-f]+|nil)'
+            return '(0x[0-9a-f]+|nil)'
         elif c == 's':
             return '.*'

More information about the Skiboot mailing list