[Skiboot] [PATCH v1] PCI: pci should throw error on platform PCI devices not being detected
stewart at linux.vnet.ibm.com
Thu Jun 16 09:16:21 AEST 2016
Mamatha Inamdar <mamatha4 at linux.vnet.ibm.com> writes:
> Thanks for the review...
> I will work on all your comments, please find my comments below
> On 06/09/2016 05:17 PM, Gavin Shan wrote:
>> On Thu, Jun 09, 2016 at 02:29:56PM +0530, Mamatha Inamdar wrote:
>>> Problem Description: Sometimes system boots to petitboot and get into a state where
>>> only the PHBs were detected and *no* other PCI devices.
>>> Fix: This patch is to check the detected PCI devices against the PCI slot
>>> table in the platform definition and display an error if they don't match
>>> and commit an errorlog.
>>> Test Results:
>>> After testing the patch, we see following traces on the SOL console.
>>> [8212824503,5] PCI: Check for a present device...
>>> [8212921065,3] Slot3 PCI: No device found
>>> [8212987391,5] Device Found in SLOT= Backplane PLX
>>> [8213085726,3] Slot4 PCI: No device found
>>> Signed-off-by: Mamatha Inamdar <mamatha4 at linux.vnet.ibm.com>
>> Mamatha, there is root port behind PHB at least. It's conflicting
>> with the PCI hotplug patchset where the "struct pci_slot_info" is
>> replaced by "struct pci_slot".
> So, Can I wait until new patchset integrated into skiboot?
I have pushed the PCI hotplug patch set to skiboot master, so this code
is now merged.
OPAL Architect, IBM.
More information about the Skiboot