[Skiboot] [PATCH 2/6] nvram: Add extra debug printing when NVRAM needs formatting

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jul 27 18:32:58 AEST 2016


Cyril Bur <cyril.bur at au1.ibm.com> writes:
> Be more verbose (at debug level) when formatting the NVRAM, this can
> help catch errors at other levels of the stack.
>
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>

Looks good, merged to master as of
d7ce0ac42b49d274c40fe8edf73b10a640116479

> --- a/core/nvram.c
> +++ b/core/nvram.c
> @@ -64,7 +64,8 @@ void nvram_read_complete(bool success)
>  
>  	/* Check and maybe format nvram */
>  	if (nvram_check(nvram_image, nvram_size)) {
> -		nvram_format(nvram_image, nvram_size);
> +		if (nvram_format(nvram_image, nvram_size))
> +			prerror("NVRAM: Failed to format NVRAM!\n");
>  
>  		/* Write the whole thing back */
>  		if (platform.nvram_write)

A patch adding FWTS annotation here would be great :)

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list