[Skiboot] [PATCH 3/6] flash: Fix 39d9e14 fail to erase flash before write

Cyril Bur cyril.bur at au1.ibm.com
Tue Jul 26 13:49:32 AEST 2016


This causes NVRAM writes to flash on OpenPOWER platforms to be
unreliable.

Fixes: 39d9e14 ("libflash: start using the blocklevel interface.")
Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
---
Let me know if theres anything you need from me to put this in stable

 core/flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/flash.c b/core/flash.c
index d3bda65..ca9cca7 100644
--- a/core/flash.c
+++ b/core/flash.c
@@ -138,7 +138,7 @@ static int flash_nvram_write(uint32_t dst, void *src, uint32_t len)
 		rc = OPAL_PARAMETER;
 		goto out;
 	}
-	rc = blocklevel_write(nvram_flash->bl, nvram_offset + dst, src, len);
+	rc = blocklevel_smart_write(nvram_flash->bl, nvram_offset + dst, src, len);
 
 out:
 	unlock(&flash_lock);
-- 
2.9.0



More information about the Skiboot mailing list