[Skiboot] [PATCH] test/hello_world: always use shutdown type zero
stewart at linux.vnet.ibm.com
Fri Jul 22 17:52:51 AEST 2016
Oliver O'Halloran <oohall at gmail.com> writes:
> The hello world kernel fails to correctly set r3 before making the
> shutdown opal call. On FSP machines only shutdown types 0 and 1 are
> recognised as valid shutdown types. If any other type is specified
> (in r3) the call is rejected with an OPAL_PARAMETER error and the
> machine will continue running.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> test/hello_world/hello_kernel/hello_kernel.S | 1 +
> 1 file changed, 1 insertion(+)
OMG MORE INSTRUCTION BLOAT!
I'm amazed at how many bugs were in hello world :)
Merged to master as of 34012377c29895db060c44ae0ceab8147cce728d
OPAL Architect, IBM.
More information about the Skiboot