[Skiboot] [PATCH] test/hello_world: always use shutdown type zero

Oliver O'Halloran oohall at gmail.com
Fri Jul 22 15:39:05 AEST 2016


The hello world kernel fails to correctly set r3 before making the
shutdown opal call. On FSP machines only shutdown types 0 and 1 are
recognised as valid shutdown types. If any other type is specified
(in r3) the call is rejected with an OPAL_PARAMETER error and the
machine will continue running.

Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
 test/hello_world/hello_kernel/hello_kernel.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/hello_world/hello_kernel/hello_kernel.S b/test/hello_world/hello_kernel/hello_kernel.S
index 6cc6409c07fc..fecf5a3fb3cc 100644
--- a/test/hello_world/hello_kernel/hello_kernel.S
+++ b/test/hello_world/hello_kernel/hello_kernel.S
@@ -47,6 +47,7 @@ here:	mflr	%r8 /* work out where we are running */
 	bctrl
 
 	li	%r0, 5 /* OPAL_CEC_POWER_DOWN */
+	li	%r3, 0 /* normal shutdown */
 	mr	%r2, %r13
 	mtctr	%r14
 	bctrl
-- 
2.5.5



More information about the Skiboot mailing list