[Skiboot] [PATCH] make check: Use mktemp instead of tempfile

[Patrick Williams]

On Sat, Jul 16, 2016 at 11:49:30PM +0530, Vasant Hegde wrote:
> Commit 2ceb8b8c (make check: make test runs less noisy) used tempfile
> command to create temporary files. Looks like distros like Fedora
> doesn't have tempfile command.
> 
> Looks like mktemp is supported on all distros (at least Fedora and
> Ubuntu supports this command). Hence replace tempfile with mktemp.
> 
> Output without patch:
>   [ CLEANUP ]   gard-test-clean
>   ./test/run.sh: line 3: tempfile: command not found
>   skiboot/external/gard/test/Makefile.check:18: recipe for target 'gard-test-clean' failed
> 	make: *** [gard-test-clean] Error 1
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> CC: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  test/run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/run.sh b/test/run.sh
> index 5185f5a..e159bd3 100755
> --- a/test/run.sh
> +++ b/test/run.sh
> @@ -1,6 +1,6 @@
>  #!/bin/bash
>  
> -t=$(tempfile) || exit 1
> +t=$(mktemp) || exit 1

Confirmed RHEL6 also has 'mktemp'.

Reviewed-by: Patrick Williams <stwcx.xyz>

>  
>  trap "rm -f -- '$t'" EXIT
>  
> -- 
> 2.5.5
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20160718/59c314e1/attachment.sig>